docs: fix typo with Embedder service #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iyadhfaleh
force-pushed
the
fix/typo-embedder-to-embeddingProvider
branch
from
6db3e12 to
6659849
Compare
chr-hertel
reviewed
Mar 29, 2025
README.md
Outdated
| @@ -350,23 +350,23 @@ $eventDispatcher->addListener(ToolCallsExecuted::class, function (ToolCallsExecu | |||
| LLM Chain supports document embedding and similarity search using vector stores like ChromaDB, Azure AI Search, MongoDB | |||
| Atlas Search, or Pinecone. | |||
|
|
|||
| For populating a vector store, LLM Chain provides the service `DocumentEmbedder`, which requires an instance of an | |||
| For populating a vector store, LLM Chain provides the service `EmbeddingProvider`, which requires an instance of an | |||
There was a problem hiding this comment.
this is the actual typo, right?
Suggested change
| For populating a vector store, LLM Chain provides the service `EmbeddingProvider`, which requires an instance of an | |
| For populating a vector store, LLM Chain provides the service `Embedder`, which requires an instance of an |
The renaming from DocumentEmbedder to Embedder was intended and part of #140
There was a problem hiding this comment.
Yes , I reverted naming changes , I let just fix for the README file
chr-hertel
requested changes
Mar 29, 2025
Iyadhfaleh
force-pushed
the
fix/typo-embedder-to-embeddingProvider
branch
3 times, most recently
from
c015069 to
916bd2d
Compare
Iyadhfaleh
force-pushed
the
fix/typo-embedder-to-embeddingProvider
branch
from
916bd2d to
dc3672a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ,
This PR is a suggestion to change the name of embedding providers variables and classes .
If you accept my suggestion , the PR to adopt this into the bundle is almost ready .