Skip to content

Use Separate Config for Each Instance of ShopifySDK #329

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jaywilliams
Copy link

This pull-request includes the code changes by @n3o77 to change the ShopifySDK config from a single, shared static config to local for each instance.

This allows you to configure multiple Shopify store connections, all within the same PHP script.

This pull-request resolves the following issues: #61, #226

@n3o77
Copy link
Contributor

n3o77 commented Jul 3, 2024

Hi, suprised you found those changes ;)

Please keep in mind that i never wrote / updated tests nor did i test everything in the library to see if anything breaks. IIRC i knew that it could make problems with the curl config or something request related, not sure anymore. Which is why i never opened a PR as i didn't have the time to make sure that it won't affect anything else.

But it solved every problem i had and so it was good enough for for that project, which still runs in production with those changes.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants