Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

use system_time_zone to encode kv if tidb set it #564

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Feb 5, 2021

What problem does this PR solve?

Resolve #562

What is changed and how it works?

if tidb time_zone is "SYSTEM", try to use "system_time_zone" to set time_zone for lightning session.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Release note

  • Fix the issue that lightning didn't use tidb's time zone to encode timestamp data.

@3pointer
Copy link
Contributor Author

/run-integration-tests

@3pointer 3pointer changed the title WIP: use system_time_zone to encode kv if tidb set it use system_time_zone to encode kv if tidb set it Feb 19, 2021
@glorv
Copy link
Contributor

glorv commented Feb 19, 2021

@3pointer Please add a unit test and an integration test

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb-lightning alters the values of timestamp columns
2 participants