Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update optional leaflet dependency to (latest) stable version #227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Thijss
Copy link

@Thijss Thijss commented Apr 5, 2025

Description of changes

The optional leaflet dependency currently points to a release candidate.
To me, it seems better to point to a stable release instead.
Coincidentally, dash-leaflet 1.1.* was released today.

Note: dash-leaflet 1.1.0 had an issue (see here), so I set the minimal requirement to 1.1.1

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • At least one person has 💃'd the pull request.

Closes #220

Other comments

Python version

The miminum python requirement for dash-leaflet is now >3.12, while for dash-cytoscape it is python_requires=">=3.8"
Might be a good idea to start updating the minimum python version of dash-cytoscape too. For example, python 3.8 has already reached end-of-life (https://devguide.python.org/versions/)

In my experience, supporting the latest 3 stable versions (3.12, 3.13, 3.14) is a good practice

@Thijss
Copy link
Author

Thijss commented Apr 5, 2025

All changes were documented in CHANGELOG.md.

Is this an automatic process or do I need to update CHANGELOG.md manually?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dash_leaflet dependency to v1.0.16
1 participant