Update optional leaflet dependency to (latest) stable version #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The optional leaflet dependency currently points to a release candidate.
To me, it seems better to point to a stable release instead.
Coincidentally, dash-leaflet 1.1.* was released today.
Note: dash-leaflet 1.1.0 had an issue (see here), so I set the minimal requirement to 1.1.1
Pre-Merge checklist
npm run build:all
.Closes #220
Other comments
Python version
The miminum python requirement for dash-leaflet is now
>3.12
, while for dash-cytoscape it ispython_requires=">=3.8"
Might be a good idea to start updating the minimum python version of dash-cytoscape too. For example, python 3.8 has already reached end-of-life (https://devguide.python.org/versions/)
In my experience, supporting the latest 3 stable versions (3.12, 3.13, 3.14) is a good practice