Skip to content

Fixed typo - calculcations of shared Y axis was using X axes #1848

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okhoma
Copy link

@okhoma okhoma commented Sep 8, 2020

No description provided.

@cpsievert
Copy link
Collaborator

Thanks, do you have minimal example(s) that demonstrate the fix (better yet, can you add some unit test(s))?

@okhoma
Copy link
Author

okhoma commented Sep 17, 2020

@cpsievert, Is it really just a copy/paste error. It's only effect, as far as I can tell, is a warning:

p <- lapply(c("A", "B", "C"), function(x) plot_ly(x = x, y = 1, type = "bar"))
subplot(subplot(p[[1]], p[[2]], shareY = TRUE), p[[3]], shareY = TRUE)
Warning message:
In seq_len(nrows * unique(xAxisN)) :
  first element used of 'length.out' argument

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants