-
-
Notifications
You must be signed in to change notification settings - Fork 53
feat: Added Into<DataFrame> trait to JsDataFrame #328
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
napi = { version = "2.16.16", default-features = false, features = [ | ||
"napi8", | ||
"serde-json", | ||
napi = { version = "3.0.0-alpha.29", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason you are using alpha version here? This is a stable library, hoping to avoid living on the edge.
@@ -0,0 +1,2 @@ | |||
[toolchain] | |||
channel = "nightly-2025-05-05" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to match polars rs-0.47
branch which currently is on nightly-2025-04-19
We also need to use the same nightly for CI/CD.
5 deprecated warnings:
|
Tests fail due to: |
Hi! Sorry, I did not realized that the commits made after creating the pull request would retroactively affect the PR. This was supposed to contain only the change in the title, and everything else I was gonna make a dedicated issue and PR for. All the commits after the first are a very early attempt at migrating this library to the latest (0.47) version of polars. Also, |
Pull request associated to issue #327.