Skip to content

fix: deadlock in send queue #211

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 20, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions mamonsu/lib/queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,21 @@ def __init__(self):
self.lock = threading.Lock()

def add(self, metric):
self.lock.acquire()
self.queue.insert(0, metric)
self.lock.release()
with self.lock:
self.queue.insert(0, metric)

# replace last metric
def replace(self, metric):
self.lock.acquire()
self.queue.pop()
self.queue.append(metric)
self.lock.release()
with self.lock:
if self.queue:
self.queue.pop()
self.queue.append(metric)

def size(self):
self.lock.acquire()
result = len(self.queue)
self.lock.release()
return result
with self.lock:
return len(self.queue)

def flush(self):
self.lock.acquire()
result, self.queue = self.queue, []
self.lock.release()
return result
with self.lock:
result, self.queue = self.queue, []
return result