-
Notifications
You must be signed in to change notification settings - Fork 358
Added Node-Js SuperAgent Code Generator #238
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: develop
Are you sure you want to change the base?
Conversation
Hey @ajwad-shaikh , could you post some example snippets generated for a |
Sure @shreys7! I have compiled a few results that the generator returns for the newman tests
|
Any updates? @shreys7 |
@shreys7 Can you give me a heads up on this? Maybe some feedback Thanks, been a long time. |
Good work @ajwad-shaikh 👏 |
`${indentString}}))\n`; | ||
break; | ||
case 'formdata': | ||
bodySnippet = `${extractFormData(requestBody[requestBody.mode], indentString, trimBody, requestBody.mode)}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a \n
is missing at the end for formdata case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out @shreys7
I have added a commit to correct this ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing because of #246
…ostman-code-generators into nodejs-superagent Merging new changes from 'master'
Hey @shreys7, Still awaiting your review on this 😄 Thanks! |
What it does?
Fixes (postmanlabs/postman-app-support#6331)
Adds support for Node-Js SuperAgent CodeGenerator in the project.
What changes you made?
There are no changes to the core structure of the project. I have only added one more codegen directory. The README is updated to include the NodeJs-SuperAgent Support. Other than that there are no changes to any file outside the
codegen/nodejs-superagent
directory.Would appreciate a review by the maintainers, @umeshp7 @shreys7
Let me know if I've missed anything.