Skip to content

Split testBouncer into unit tests + add testChannelMessageFromSelf and testDirectMessageFromOther #303

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

progval
Copy link
Owner

@progval progval commented Mar 29, 2025

No description provided.

@progval progval requested a review from Copilot March 29, 2025 16:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request splits the existing testBouncer functionality into distinct unit tests and adds new tests for channel and direct messages in various client scenarios.

  • Introduces a setUp method in place of testBouncer for shared client registration.
  • Adds new tests for automatic session resumption, message relaying for both self and others, and quitting behavior.
  • Refactors client connection methods to support different capability scenarios.
Comments suppressed due to low confidence (2)

irctest/server_tests/bouncer.py:125

  • Both 'messagesfortwo' and 'messagesforone' are obtained using self.getMessages(2) but are expected to yield different results. Verify if one of these should reference a different client to correctly test echo-message behavior.
messagesforone = [msg for msg in self.getMessages(2) if msg.command == "PRIVMSG"]

irctest/server_tests/bouncer.py:115

  • [nitpick] The docstring for testChannelMessageFromSelf is identical to that of testChannelMessageFromOther, which may cause confusion. Update the documentation to clearly reflect that this test verifies behavior for messages sent from the self client and the absence of echo messages.
def testChannelMessageFromSelf(self):

Copy link

Test results

Copy link

Test results

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant