Collect idle_in_transaction_time from PG >= 15 #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sticksman
approved these changes
Oct 17, 2024
idle_in_transaction_time was added to pg_stat_database in pg 15 Signed-off-by: Alexander J. Maidak <amaidak@equinix.com>
ajmaidak
force-pushed
the
add-idle-trx-time-metric
branch
from
b262eec to
69c4119
Compare
sysadmind
requested changes
Feb 15, 2025
| @@ -375,6 +393,11 @@ func (c *PGStatDatabaseCollector) Update(ctx context.Context, instance *instance | |||
| continue | |||
| } | |||
|
|
|||
| if idleInTransactionTimeAvail && !idleInTransactionTime.Valid { | |||
| level.Debug(c.log).Log("msg", "Skipping collecting metric because it has no idle_in_transaction_time") | |||
| continue | |||
There was a problem hiding this comment.
I don't think this needs to skip the whole row in this case. I think this logic can be to skip sending the metric to the channel down on line 540 instead. I know the logic above is this way, but I think technically this addition could break things for other users if this field is NULL, so I want to avoid that.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idle_in_transaction_time was added to pg_stat_database in pg 15
https://www.postgresql.org/docs/15/monitoring-stats.html#MONITORING-PG-STAT-DATABASE-VIEW