Feat: Improve Error Handling for Server.Scrape #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoweFlex
force-pushed
the
improve-namespace-errorhandling
branch
from
0c0a5e1 to
05f7277
Compare
If there are errors querying namespace mappings, the potential error from querySettings is obscured. Adding an immediate return if there are errors retreiving settings. Signed-off-by: Jonathan Bowe <jonathan@bowedev.com>
BoweFlex
force-pushed
the
improve-namespace-errorhandling
branch
from
05f7277 to
1b08472
Compare
sysadmind
requested changes
May 19, 2025
BoweFlex
force-pushed
the
improve-namespace-errorhandling
branch
from
1b08472 to
6ba9241
Compare
Previously if any errors were encountered by queryNamespaceMappings, only a count of those errors was returned - making debugging those errors harder than it needs to be. I'm changing this to immediately return nil if no errors are encountered, and otherwise an error will be formatted with each of the namespaces and what the error was for that namespace. Signed-off-by: Jonathan Bowe <jonathan@bowedev.com>
BoweFlex
force-pushed
the
improve-namespace-errorhandling
branch
from
6ba9241 to
af34eba
Compare
SuperQ
reviewed
May 21, 2025
| } | ||
| err = fmt.Errorf("queryNamespaceMappings errors encountered") | ||
| for namespace, errStr := range errMap { | ||
| err = fmt.Errorf("%s, %s namespace had the following error: %s", err, namespace, errStr) |
There was a problem hiding this comment.
Minor nit to make it a little simpler to read (and shorter).
Suggested change
| err = fmt.Errorf("%s, %s namespace had the following error: %s", err, namespace, errStr) | |
| err = fmt.Errorf("%s, namespace: %s error: %s", err, namespace, errStr) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if any errors were encountered by queryNamespaceMappings, only a count of those errors was returned - making debugging those errors harder than it needs to be.
I'm changing this to immediately return nil if no errors are encountered, and otherwise an error will be formatted with each of the namespaces and what the error was for that namespace.
Additionally, if any errors were encountered during querySettings, they were potentially obscured by queryNamespaceMappings errors. I've added an immediate return if errors are found during querySettings to ensure these errors are visible.