Skip to content

Additional tests for Element#makeClipping(), Element#undoClipping() #46

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Additional tests for Element#makeClipping(), Element#undoClipping() #46

wants to merge 1 commit into from

Conversation

victor-homyakov
Copy link
Contributor

See ticket #1063:

  1. Current implementation doesn't work properly for inline style="overflow:auto;"
  2. Inline style isn't restored properly after undoClipping() - it is replaced with computed style
  3. Computing style with Element.getStyle() isn't needed - performance optimization is possible

@savetheclocktower
Copy link
Collaborator

I'll use these tests to help me fix #1063. Until then, I'll keep this open because I don't want to commit tests without the fix that will make them pass. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victor-homyakov @savetheclocktower