chore: update V8 to 13.8.258.26 #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonm1
requested review from
PiotrSikora,
martijneken and
mpwarres
as code owners
Signed-off-by: Michael Warres <mpw@google.com>
Signed-off-by: Michael Warres <mpw@google.com>
PiotrSikora
reviewed
Jul 17, 2025
leonm1
force-pushed
the
chore/update-v8
branch
2 times, most recently
from
3e9f030 to
1caa20f
Compare
martijneken
approved these changes
Jul 18, 2025
leonm1
force-pushed
the
chore/update-v8
branch
2 times, most recently
from
aabaa9e to
0304328
Compare
leonm1
force-pushed
the
chore/update-v8
branch
7 times, most recently
from
b213f3d to
c9c9eb2
Compare
mpwarres
approved these changes
Jul 18, 2025
Signed-off-by: Matt Leon <mattleon@google.com>
leonm1
force-pushed
the
chore/update-v8
branch
2 times, most recently
from
9c8fcba to
8f1af46
Compare
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
This test fails with the new V8 version Signed-off-by: Matt Leon <mattleon@google.com>
BSD sed requires an extension to create a backup file when used with in-place editing. Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Fixes macos build Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
leonm1
force-pushed
the
chore/update-v8
branch
2 times, most recently
from
ba138c5 to
aa952fb
Compare
Signed-off-by: Matt Leon <mattleon@google.com>
phlax
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Jul 22, 2025
Commit Message: deps: update `v8` to 13.8.258.26 Additional Description: Includes the requisite updates to proxy_wasm_cpp_host and new v8 dependencies. Tested with `bazel test test/extensions/filters/http/wasm/... --define wasm=v8` (and `--define wasm=wasmtime` and `--define wasm=wamr` for defense in depth). Proxy-wasm-cpp-host patches come from proxy-wasm/proxy-wasm-cpp-host#442 Fix #28336 --------- Signed-off-by: Matt Leon <mattleon@google.com> Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jul 23, 2025
Commit Message: deps: update `v8` to 13.8.258.26 Additional Description: Includes the requisite updates to proxy_wasm_cpp_host and new v8 dependencies. Tested with `bazel test test/extensions/filters/http/wasm/... --define wasm=v8` (and `--define wasm=wasmtime` and `--define wasm=wamr` for defense in depth). Proxy-wasm-cpp-host patches come from proxy-wasm/proxy-wasm-cpp-host#442 Fix envoyproxy#28336 --------- Signed-off-by: Matt Leon <mattleon@google.com> Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
These warnings flag a Join() function protected by a mutex. Such a function marks that the racy operation has ended. Signed-off-by: Matt Leon <mattleon@google.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of #441.