Skip to content

Make map serialization/deserialization utils public #125

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krdln
Copy link

@krdln krdln commented Sep 16, 2021

(see commit messages)

We don't need ownership, so slice should be enough.

Note: Public-facing functions still do take Vecs as arguments, to avoid
breaking changes. They could also be changed to take slices in the
future.

Signed-off-by: Michał Krasnoborski <michal.krasnoborski@fluxninja.com>
These functions are helpful as "serialized map" format is used in some
other places, eg. in envoy `get_property(["metadata", "filter_metadata",
"xxx"])` may return a map in such a format.

Signed-off-by: Michał Krasnoborski <michal.krasnoborski@fluxninja.com>
@krdln krdln requested a review from PiotrSikora as a code owner September 16, 2021 14:02
@google-cla
Copy link

google-cla bot commented Sep 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@PiotrSikora
Copy link
Member

Hi @krdln! Could you check the CLA? It looks that the email is on file, but your GitHub username is not.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants