Fix for correctly including packages.config and internalPackages.config from Nuget-Project. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig from Nuget-Project.
|
Hi, thanks for the fix. Can you add an example to one of the test projects? |
|
Unit test created |
DannyVarod
reviewed
Jan 19, 2018
| @@ -178,6 +178,23 @@ public void TestGetDependenciesInner() | |||
| && ((XElement)obj).Attribute("version").Value == "1.24.0"); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void TestGetDependencies_InternalPackages() | |||
There was a problem hiding this comment.
This test passes with and without the fix
There was a problem hiding this comment.
Oops, of course, it was a wrong test. Correction made.
|
Any timeline on this being merged and getting a new release out? This issue is preventing any of my nuget dependencies being included in the nuspec file... can you suggest any workaround in the mean time? Great package by the way. |
…automatically, without excplicitly adding them into NuGet Package project.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4 - Fix for correctly including packages.config and internalPackages.config from Nuget-Project.