Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Timeout for sms_list and fixed memory leak #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bokolob
Copy link

@bokolob bokolob commented Sep 1, 2020

No description provided.

@pulkin
Copy link
Owner

pulkin commented Sep 6, 2020

I do not quite understand what kind of memory leak you refer to. sms_list_buffer is inside the garbage-collected mpy heap so no need to delete it. Besides, what happens if you call SMS.list twice in a row? The script won't be happy if you delete the first list it is using preventively.

@bokolob
Copy link
Author

bokolob commented Sep 7, 2020

If you call list twice then pointer will be rewritten, but memory not freed. I suppose that gc cannot control pointers inside C code.

@bokolob
Copy link
Author

bokolob commented Sep 7, 2020

As I understand list isn’t used if pointer is not null. And I didn’t change this logic. Could you explain your point please ?

@bokolob
Copy link
Author

bokolob commented Nov 12, 2020

Hello! Can we return to disscussing this issue?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants