Move expectation out of let block #2558
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Aug 16, 2024
ekohl
commented
Aug 17, 2024
| it { | ||
| expect(subject).to contain_concat__fragment('rspec.example.com-apache-userdir') | ||
| .with(content: %r{^\s+UserDir disabled$}) | ||
| .with(content: %r{^\s+UUserDir enabled bob$}) |
There was a problem hiding this comment.
Looks like there was already a typo in UUserDir here, which is proof the test didn't ran.
bastelfreak
previously approved these changes
Aug 17, 2024
Otherwise it isn't executed. Fixes: ec74a8e ("Add support for setting UserDir in Virtual Hosts")
smortex
approved these changes
Sep 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Otherwise it isn't executed.
Related Issues (if any)
Fixes: ec74a8e ("Add support for setting UserDir in Virtual Hosts")
Checklist
puppet apply)