Skip to content

Introduce lib finalize method #184

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bukka
Copy link

@bukka bukka commented Nov 19, 2024

This is to allow explicit calling of C_Finalize.

My use case is a test for my fork of pkcs11-proxy where I added tests which use this project. The way how pkcs11-proxy works is that it creates a daemon which gets the proxied calls. The issue that I have is that in my test I can start the daemon but then I need to also terminate it. However the termination should happen after getting C_Finalize which is difficult to do in pkcs11-proxy because it happens at the end when the garbage is collected. So I would like to do an explicit call to do finalize and then terminate the daemon.

This is to allow explicit calling of C_Finalize
@mathiasertl
Copy link
Collaborator

LGTM, but we should also test and document this function.

Btw. It might also solve an issue I encountered with the unit tests for my own project.

@bukka
Copy link
Author

bukka commented Nov 20, 2024

Cool. I will try to put together some test in the coming weeks and also update the docs.

@mathiasertl
Copy link
Collaborator

Thanks! Otherwise I see no reason against a merge!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants