-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Replacing ICC C++14 with C++17 #3570
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
7014775
to
4d501a1
Compare
@rscohn2 @xmnboy would this be an oneAPI
This looks like a general problem with pybind11/include/pybind11/stl.h Line 31 in 2cd32e5
We see this on our GitHub actions CI, using the |
I filed a ticket. I don't know if it will be fixed because there are workarounds (disabling warnings) and we are transitioning to icpx. Here is the reproducer:
|
The changes you proposed are good workarounds, and I am glad to see you are adding icpx support. |
Try to suppress the `-Werror-all` promotion in `#include <variant>`
@rscohn2 is there a way to enable building with |
Try maybe -Wno-conversion?
|
CI is running. |
For quality assurance, copying parts of the C++11 and C++17 compilation commands from the log:
|
@henryiii @ax3l @Skylion007 I think this is good to go in. |
In view of the transition to icpx, I feel it's not worth the effort troubleshooting the icpc C++20 issue(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, irritating to have to turn off a warning, but it's not ours (and the other compilers should catch if we make a mistake)
Description
This PR reverts most of PR #3551. To work around the issue that started with Intel 2021.5.0.20211109,
-Wno-conversion
is added specifically for C++17 (as recommended here: #3570 (comment)).Quality assurance: #3570 (comment)
Original PR description
For reporting to Intel.
The C++17 build was working with
but started failing with
See also: PR #3551
Suggested changelog entry: