Skip to content

better test for const only smart ptr #5727

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

better test for const only smart ptr #5727

merged 1 commit into from
Jun 14, 2025

Conversation

Rosdf
Copy link
Contributor

@Rosdf Rosdf commented Jun 14, 2025

Description

Fix test to check compilation of const only smart ptr
continuation of #5718

Suggested changelog entry:

  • Placeholder.

@Rosdf Rosdf mentioned this pull request Jun 14, 2025
Closed
rwgk
rwgk approved these changes Jun 14, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I verified that this covers all three production code changes, and while I was at it, also that the new test doesn't leak (as expected).

@rwgk rwgk merged commit f3bb007 into pybind:master Jun 14, 2025
82 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jun 14, 2025
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jun 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rwgk rwgk rwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rosdf @rwgk @henryiii