Fix tutorial.md typo about adding tests #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the "Adding Python Source Files" section, towards the end when talking about test coverage, the tutorial says we have two options: 1. Override the coverage plugin default setting and disable failure on missing code coverage threshold. 2. Add a test that ensures that the code is properly tested. Then it says: "Being a diligent responsible developer that follows 21-st century best practices we will choose the **first option** and add an appropriate test." The option to add a test would be the second one, not the first one. I change "first option" to "second option" because that appears to be the author's original intent.
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "Adding Python Source Files" section, towards the end when talking about test coverage, the tutorial says we have two options:
Then it says: "Being a diligent responsible developer that follows 21-st century best practices we will choose the first option and add an appropriate test."
The option to add a test would be the second one, not the first one. I change "first option" to "second option" because that appears to be the author's original intent.