fix: submodel fields with wrap validator affect smart union selection #1700
Conversation
| // state.exactness = self.exactness; | ||
| // state.fields_set_count = self.fields_set_count; |
There was a problem hiding this comment.
@Viicos I'm not sure that these are being used at the moment for validate_assignment. I don't see any explicit use for these — I've also added an additional assertion in the added test.
But maybe Chesterton's Fence in effect 😄
Let me know if I should keep it
There was a problem hiding this comment.
Nice catch, I'm tempted to leave it and add a TODO is it necessary to report the state for validate_assignment?, but is this TODO going to be solved anytime.. 😄 thoughts @davidhewitt?
There was a problem hiding this comment.
I'll dig into it a bit more to see if this state is necessary on validate_assignment, but if I can't figure it out this week then I'll just add the TODO and leave it
|
please review |
CodSpeed Performance ReportMerging #1700 will not alter performanceComparing Summary
|
Change Summary
fields_set_countstate when validating submodelsRelated issue number
Fixes pydantic/pydantic#11752
Checklist
pydantic-core(except for expected changes)Selected Reviewer: @davidhewitt