-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Add ROI selection to stage explorer, and scan button to scan selected ROI #428
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (46.17%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 90.53% 89.06% -1.48%
==========================================
Files 90 91 +1
Lines 9850 10150 +300
==========================================
+ Hits 8918 9040 +122
- Misses 932 1110 +178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roi = ROIRectangle(self._stage_viewer.view.scene) | ||
roi.visible = True | ||
roi.set_selected(True) | ||
roi.set_anchor(roi._canvas_to_world(canvas_pos)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i made some additional cleanups on ROI. Next thing I see that we should do is here: we should pass the canvas position into the creation of the ROIRectangle, so that the very first place that the handles are positioned is correctly in world space. (i.e. "please create an ROIRectangle
at this position`), to avoid a flash of seeing the handles at the origin, and then quickly moving them when the mouse drags
…ore-widgets into stage-explorer-rois
…ore-widgets into stage-explorer-rois
did a number of updates here, added an ROI manager, and a "scan selected ROI" button. movie added to original post |
Untitled.mov