Skip to content

feat: Add ROI selection to stage explorer, and scan button to scan selected ROI #428

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented May 7, 2025

Untitled.mov

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 46.17647% with 183 lines in your changes missing coverage. Please review.

Project coverage is 89.06%. Comparing base (c4b863d) to head (65bf77f).

Files with missing lines Patch % Lines
.../pymmcore_widgets/control/_stage_explorer/_rois.py 36.81% 127 Missing ⚠️
...widgets/control/_stage_explorer/_stage_explorer.py 54.78% 52 Missing ⚠️
...e_widgets/control/_stage_explorer/_stage_viewer.py 83.33% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (46.17%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   90.53%   89.06%   -1.48%     
==========================================
  Files          90       91       +1     
  Lines        9850    10150     +300     
==========================================
+ Hits         8918     9040     +122     
- Misses        932     1110     +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 721 to 724
roi = ROIRectangle(self._stage_viewer.view.scene)
roi.visible = True
roi.set_selected(True)
roi.set_anchor(roi._canvas_to_world(canvas_pos))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i made some additional cleanups on ROI. Next thing I see that we should do is here: we should pass the canvas position into the creation of the ROIRectangle, so that the very first place that the handles are positioned is correctly in world space. (i.e. "please create an ROIRectangle at this position`), to avoid a flash of seeing the handles at the origin, and then quickly moving them when the mouse drags

@tlambert03
Copy link
Member

did a number of updates here, added an ROI manager, and a "scan selected ROI" button. movie added to original post

@tlambert03 tlambert03 changed the title [WIP]: feat: add rois to the stage explorer feat: Add ROI selection to stage explorer, and scan button to scan selected ROI May 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants