Replace loadDynlibsFromPackage and get_dynlibs with install API
#235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
reviewed
May 26, 2025
| ) -> None: | ||
| pass | ||
| from micropip.metadata import wheel_dist_info_dir |
There was a problem hiding this comment.
Shouldn't this go below the docstring?
There was a problem hiding this comment.
Right. Thanks for the catch.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts
installfunction (pyodide/pyodide#4914), which is a stable API for installing packages that Pyodide runtime provides.It replaces other compatibility functions such as
loadDynlibsFromPackageandget_dynlibs, and removes duplicate codes.