Standardize GitHub actions setup python #1763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit will fix the error here as well and are unrelated to the scope of the pr |
|
Looks like the version isn't updated everywhere. Also, I wouldn't rush to bump it. Updating the actions is fine, though. But the PR title/description should say so. |
clintonsteiner
force-pushed
the
standardizeGithubActionsSetupPython
branch
from
260ee51 to
8a1d22d
Compare
|
Updating it just in the contributing section which is discussing specifically what's being used in ci to build the docs Fixed the missing version update, thanks @webknjaz |
webknjaz
reviewed
Jan 14, 2025
| @@ -134,9 +134,9 @@ need: | |||
|
|
|||
| python -m pip install --user nox | |||
|
|
|||
| 2. Python 3.11. Our build scripts are usually tested with Python 3.11 only. | |||
| 2. Python 3.13. Our build scripts are usually tested with Python 3.11 only. | |||
There was a problem hiding this comment.
This says we use 3.11 in tests.
|
I think we were usually trying to have older Python versions to accommodate for contributors unable to upgrade to the latest… I'm not entirely sure if we should jump right into 3.13. Perhaps other people would have extra opinions, though. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://python-packaging-user-guide--1763.org.readthedocs.build/en/1763/