Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update ci workflows #1775

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

clintonsteiner
Copy link
Contributor

@clintonsteiner clintonsteiner commented Jan 7, 2025

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is initially interesting, but I have a better example.
Mimic these if you want to continue working on this PR: https://github.com/ansible/receptor/blob/794e4c402c7045091e111a3bfc97722a2af214ba/.github/workflows/reusable-nox.yml#L58-L64 / https://github.com/ansible/receptor/blob/794e4c402c7045091e111a3bfc97722a2af214ba/.github/workflows/pull_request.yml#L87-L120. Without the go or project-specific stuff, of course. Follow the naming conventions too.

The "module" should be named reusable-*. The conditionals should live outside that reusable module. The call to nox should be split into provisioning and execution.

Besides that, I'd rather have version bumps in a separate PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants