Skip to content

WIP: add long_description to setup.py #236

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: add long_description to setup.py #236

wants to merge 2 commits into from

Conversation

basnijholt
Copy link
Member

See title ^

@basnijholt basnijholt requested a review from jbweston December 11, 2019 13:07
@akhmerov
Copy link
Contributor

Did you run twine check dist/*?

@basnijholt
Copy link
Member Author

Now I did, it uncovered a bug...

Checking dist/adaptive-0.10.0.dev14+g250ecbb-py3-none-any.whl: FAILED
  `long_description` has syntax errors in markup and would not be rendered on PyPI.
    line 64: Warning: "raw" directive disabled.
Checking dist/adaptive-0.10.0.dev14+g250ecbb.tar.gz: FAILED
  `long_description` has syntax errors in markup and would not be rendered on PyPI.
    line 64: Warning: "raw" directive disabled.

@basnijholt
Copy link
Member Author

basnijholt commented Dec 11, 2019 •
edited
Loading

It is because of the html in Examples.

I've change the image tag, but not I am running into github/markup#295.

@basnijholt basnijholt changed the title add long_description to setup.py WIP: add long_description to setup.py Dec 11, 2019
@basnijholt basnijholt force-pushed the setup.py branch 3 times, most recently from 5b6fe81 to 6dc6f79 Compare December 11, 2019 14:50
jbweston
jbweston approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good except for the bug.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jbweston jbweston jbweston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basnijholt @akhmerov @jbweston