Skip to content

Add 3.14 to Trove classifiers #1415

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add 3.14 to Trove classifiers #1415

wants to merge 6 commits into from

Conversation

Tinche
Copy link
Member

@Tinche Tinche commented Mar 10, 2025

See title.

@Tinche Tinche requested a review from hynek March 10, 2025 14:39
@webknjaz
Copy link
Member

Is there a policy for this in the project? I'm my own, I usually add a new classifier to signal that it's tested against a stable version of that project, not during the alpha phase of CPython..

@hynek
Copy link
Member

hynek commented Mar 10, 2025

The policy is that the CI runs against our trove classifiers which implies that it works.

@hynek
Copy link
Member

hynek commented May 1, 2025

FTR we're waiting for PyO3 adding 3.14 support

@hynek
Copy link
Member

hynek commented May 11, 2025

Looks like Mypy doesn't like 3.14:

py314-mypy: commands[0]> mypy tests/typing_example.py
Traceback (most recent call last):
  File "/Users/hynek/FOSS/attrs/.tox/py314-mypy/bin/mypy", line 10, in <module>
    sys.exit(console_entry())
             ~~~~~~~~~~~~~^^
  File "/Users/hynek/FOSS/attrs/.tox/py314-mypy/lib/python3.14/site-packages/mypy/__main__.py", line 15, in console_entry
    main()
    ~~~~^^
  File "/Users/hynek/FOSS/attrs/.tox/py314-mypy/lib/python3.14/site-packages/mypy/main.py", line 88, in main
    sources, options = process_options(args, stdout=stdout, stderr=stderr, fscache=fscache)
                       ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/hynek/FOSS/attrs/.tox/py314-mypy/lib/python3.14/site-packages/mypy/main.py", line 1055, in process_options
    parser.add_argument(
    ~~~~~~~~~~~~~~~~~~~^
        "--enable-incomplete-feature",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<2 lines>...
        help="Enable support of incomplete/experimental features for early preview",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/Library/Frameworks/Python.framework/Versions/3.14/lib/python3.14/argparse.py", line 1562, in add_argument
    formatter = self._get_formatter()
  File "/Library/Frameworks/Python.framework/Versions/3.14/lib/python3.14/argparse.py", line 2729, in _get_formatter
    return self.formatter_class(
           ~~~~~~~~~~~~~~~~~~~~^
        prog=self.prog,
        ^^^^^^^^^^^^^^^
        prefix_chars=self.prefix_chars,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        color=self.color,
        ^^^^^^^^^^^^^^^^^
    )
    ^
TypeError: AugmentedHelpFormatter.__init__() got an unexpected keyword argument 'prefix_chars'
py314-mypy: exit 1 (0.91 seconds) /Users/hynek/FOSS/attrs> mypy tests/typing_example.py pid=68813

@hynek
Copy link
Member

hynek commented May 11, 2025

So do we want to merge this and tackle these, or are those fixes trivial enough?

XFAIL tests/test_annotations.py::TestAnnotations::test_self_reference[False] - reason: References are changing a lot in 3.14.
[57](https://github.com/python-attrs/attrs/actions/runs/14953583335/job/42006205678?pr=1415#step:8:58)
XFAIL tests/test_annotations.py::TestAnnotations::test_forward_reference[False] - reason: Forward references are changing a lot in 3.14.
[58](https://github.com/python-attrs/attrs/actions/runs/14953583335/job/42006205678?pr=1415#step:8:59)
XFAIL tests/test_setattr.py::TestSetAttr::test_slotted_confused
[59](https://github.com/python-attrs/attrs/actions/runs/14953583335/job/42006205678?pr=1415#step:8:60)
XFAIL tests/test_slots.py::test_slots_cached_property_infers_type - 3.14 returns weird annotation for cached_properies
[60](https://github.com/python-attrs/attrs/actions/runs/14953583335/job/42006205678?pr=1415#step:8:61)
XFAIL tests/test_make.py::TestClassBuilder::test_no_references_to_original_when_using_cached_property - Currently broken on nightly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants