Skip to content

bpo-29711: Fix stop_serving in proactor loop kill all listening servers #431

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2017
Merged

bpo-29711: Fix stop_serving in proactor loop kill all listening servers #431

merged 1 commit into from
Dec 19, 2017

Conversation

julien-duponchelle
Copy link
Contributor

@julien-duponchelle julien-duponchelle commented Mar 3, 2017 •
edited by bedevere-bot
Loading

Current implementation of the asyncio Proactor event loop has an issue, when you stop a server it's cancel the futures of all other servers.

Original discussion: python/asyncio#496

https://bugs.python.org/issue29711

@mention-bot
Copy link

@noplay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Haypo and @1st1 to be potential reviewers.

@julien-duponchelle julien-duponchelle mentioned this pull request Mar 3, 2017
Open
@1st1
Copy link
Member

1st1 commented Mar 3, 2017

@Haypo Can you take a look at this PR?

@julien-duponchelle
Copy link
Contributor Author

Can I do something to help ?

vstinner
vstinner approved these changes Aug 21, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
Copy link
Member

I agree that it's plain wrong to cancel the "accept future" of all listening servers.

@1st1
Copy link
Member

1st1 commented Oct 19, 2017

Could you please add a NEWS entry using blurb?

@1st1 1st1 requested a review from asvetlov October 19, 2017 17:35
@gvanrossum gvanrossum mentioned this pull request Oct 24, 2017
Closed
@asvetlov
Copy link
Contributor

@noplay ping

@julien-duponchelle
Copy link
Contributor Author

News entry added

@1st1
Copy link
Member

1st1 commented Dec 18, 2017

Could you please rebase your PR once again?

@julien-duponchelle
Copy link
Contributor Author

It's rebase

@1st1 1st1 merged commit 319c034 into python:master Dec 19, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@julien-duponchelle @mention-bot @1st1 @vstinner @asvetlov @the-knights-who-say-ni @bedevere-bot