Skip to content

Issue 333 : Adding new optional field "Zip code" to petition signature #334

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fsellaouti
Copy link
Contributor

@fsellaouti fsellaouti commented Mar 15, 2025

close #333

@fallen fallen self-requested a review March 16, 2025 14:53
@fallen
Copy link
Member

fallen commented Mar 16, 2025

Hello @fsellaouti
Something bothers me with this new feature.
It unconditionally adds a new field to petitions (the field can be optionally filled, ok).
Maybe some other users of Pytition don't want this field, maybe they want it (like you).

I would like to make it possible to add/remove fields, for real, from the petition forms, by-petition, configurable in the web UI in the "edit petition" UI.

This would allow you to add your zip code field but would let others keep their form "small".

I honestly don't know if it's easy to do what I'm describing ... I would bet it's not easy because usually forms in Django are described by a class and backed by an sql "table" so it would not be that easy to modify those 1/ on-the-fly and 2/ by-petition.

What do you think?

@fsellaouti
Copy link
Contributor Author

Hello @fsellaouti Something bothers me with this new feature. It unconditionally adds a new field to petitions (the field can be optionally filled, ok). Maybe some other users of Pytition don't want this field, maybe they want it (like you).

I would like to make it possible to add/remove fields, for real, from the petition forms, by-petition, configurable in the web UI in the "edit petition" UI.

This would allow you to add your zip code field but would let others keep their form "small".

I honestly don't know if it's easy to do what I'm describing ... I would bet it's not easy because usually forms in Django are described by a class and backed by an sql "table" so it would not be that easy to modify those 1/ on-the-fly and 2/ by-petition.

What do you think?

Hello @fallen ,
I agree with your response.
What we can do is adding a "Fields" tab in the petition editing interface where users can choose fields to show and whether they are required or not. For now it would be only the phone number field and maybe later the zip code and even a comment for example.
But those fields would be still associated each to a column.
Otherwise, to make it dynamic you might want to add a JSON typed column but this solution might create other technical and functional problems.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zip code field to signature
2 participants