Skip to content

fix-ci #107

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 24 commits into from
Apr 22, 2025
Merged

fix-ci #107

merged 24 commits into from
Apr 22, 2025

Conversation

antgonza
Copy link
Member

@antgonza antgonza commented Apr 8, 2025

The tests are failing because the tests files used to live in qp_klp/tests/data/ and sequence_processing_pipeline/tests/data but they were moved to src/[folder] so I decided to move them outside of src; this should help with duplicated folders/files. The steps done were:

  1. mkdir tests
  2. git mv src/qp_klp/tests/* tests/
  3. git mv src/sequence_processing_pipeline/tests/data/seq_counts_logs tests/data/
  4. git mv src/sequence_processing_pipeline/tests/data/tellseq_output/ tests/data/
  5. git rm -r src/sequence_processing_pipeline/tests/data/configuration_profiles/
  6. git mv src/sequence_processing_pipeline/tests/data/sample_run_directories/ tests/data/
  7. git mv src/sequence_processing_pipeline/tests/data/211021_A00000_0000_SAMPLE/* tests/data/211021_A00000_0000_SAMPLE/
  8. rmdir src/sequence_processing_pipeline/tests/data/211021_A00000_0000_SAMPLE/
  9. git mv src/sequence_processing_pipeline/tests/data/* tests/data/
  10. rmdir src/sequence_processing_pipeline/tests/data/
  11. git mv src/sequence_processing_pipeline/tests/bin tests/
  12. rmdir src/sequence_processing_pipeline/tests/
  13. rmdir src/qp_klp/tests/
  14. git rm .//src/sequence_processing_pipeline/configuration.json

Copy link

@AmandaBirmingham AmandaBirmingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with these changes. Out of curiosity, why was it necessary to comment out cover-package?

@antgonza
Copy link
Member Author

Thank you @AmandaBirmingham. To be honest, I can fully remember, I think the problem was that it was getting confused between packages; I'll try to figure it out.

This was referenced Apr 22, 2025
@antgonza antgonza merged commit a7e1dab into qiita-spots:main Apr 22, 2025
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants