Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@
"webpack-cli": "^3.3.11"
},
"dependencies": {
"@jupyter-widgets/base": "^1.1 || ^2 || ^3",
"@jupyter-widgets/controls": "^1 || ^2",
"@jupyter-widgets/base": "^1.1 || ^2 || ^3 || ^4",
"@jupyter-widgets/controls": "^1 || ^2 || ^3",
"clean": "^4.0.2",
"jquery": "^3.2.1",
"jquery-ui-dist": "^1.12.1",
"moment": "^2.24.0",
Expand Down
6 changes: 0 additions & 6 deletions js/src/qgrid.widget.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ var text_filter = require('./qgrid.textfilter.js');
var boolean_filter = require('./qgrid.booleanfilter.js');
var editors = require('./qgrid.editors.js');
var dialog = null;
try {
dialog = require('base/js/dialog');
} catch (e) {
console.warn("Qgrid was unable to load base/js/dialog. " +
"Full screen button won't be available");
}
var jquery_ui = require('jquery-ui-dist/jquery-ui.min.js');

require('slickgrid-qgrid/slick.core.js');
Expand Down
2 changes: 1 addition & 1 deletion js/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ module.exports = [
module: {
rules: rules
},
externals: ['@jupyter-widgets/base', '@jupyter-widgets/controls', 'base/js/dialog'],
externals: ['@jupyter-widgets/base', '@jupyter-widgets/controls'],
plugins: plugins,
mode: 'production'
},
Expand Down