ENH/BUG: Make emission_rate configurable in run_algorithm #2080
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
emission_ratein sim_params defaults todaily.Defaulting to
dailybreaks minute-level benchmarks forset_benchmark(See #1827) because BenchmarkSource._initialize_precalculated_series chooses the frequency for looking up the benchmark data based onemission_rate. Daily -> daily reader -> KeyError.Alternatives to exposing
emission_rateto fix this benchmark issue seems to be either:set_benchmarkto specify the benchmark's rate (ex:set_benchmark(0, benchmark_frequency='minute'))data_frequency- seems wrongLet me know what I can add in terms of tests if this is a good approach.