Skip to content

[QEff Finetune]: Implement logger for finetuning and enable dumping #371

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Jul 9, 2025

Conversation

quic-mamta
Copy link
Contributor

@quic-mamta quic-mamta commented Apr 21, 2025

  1. Implement logger for finetuning
  2. enable dumping logs by given flag

@quic-mamta quic-mamta requested review from quic-swatia and vbaddi and removed request for ochougul and quic-rishinr April 21, 2025 09:08
@quic-mamta quic-mamta self-assigned this Apr 21, 2025
@quic-mamta quic-mamta marked this pull request as draft April 21, 2025 09:18
Copy link
Contributor

@vbaddi vbaddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge this?

Copy link
Contributor

@quic-meetkuma quic-meetkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it is a good change, Mamta! Let us try to include more things as suggested.

Copy link
Contributor

@quic-meetkuma quic-meetkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address this one as well.

@quic-mamta quic-mamta force-pushed the use_logger branch 3 times, most recently from 79a2115 to 2de4c6f Compare May 22, 2025 18:31
@quic-mamta quic-mamta force-pushed the use_logger branch 3 times, most recently from 1fc9ef2 to f97b24e Compare May 26, 2025 13:54
@vbaddi
Copy link
Contributor

vbaddi commented Jun 20, 2025

@mamtsing can you pls rebase and confirm if this logs file will be stored in the default qeff cache path?
We should close this PR asap!

@quic-mamta quic-mamta force-pushed the use_logger branch 4 times, most recently from 99eb8ce to 203a358 Compare June 23, 2025 12:29
Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
@quic-mamta quic-mamta force-pushed the use_logger branch 2 times, most recently from 7c2787a to 1833204 Compare July 9, 2025 10:43
Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
@quic-mamta quic-mamta changed the title [QEff Finetune]: Use logger in place of print statements in finetuning scripts [QEff Finetune]: Implement logger for finetuning and enable dumping Jul 9, 2025
@quic-mamta quic-mamta marked this pull request as ready for review July 9, 2025 14:15
@quic-mamta quic-mamta merged commit 30d1579 into quic:main Jul 9, 2025
4 checks passed
quic-amitraj pushed a commit that referenced this pull request Jul 10, 2025
…371)

1. Implement logger for finetuning
2. enable dumping logs by given flag

---------

Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Co-authored-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
quic-amitraj pushed a commit that referenced this pull request Jul 10, 2025
…371)

1. Implement logger for finetuning
2. enable dumping logs by given flag

---------

Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Co-authored-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Signed-off-by: Amit Raj <amitraj@qti.qualcomm.com>
quic-amitraj pushed a commit that referenced this pull request Jul 10, 2025
…371)

1. Implement logger for finetuning
2. enable dumping logs by given flag

---------

Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Co-authored-by: Mamta Singh <mamtsing@qti.qualcomm.com>
quic-dhirajku pushed a commit to quic-dhirajku/efficient-transformers that referenced this pull request Aug 4, 2025
…uic#371)

1. Implement logger for finetuning
2. enable dumping logs by given flag

---------

Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Co-authored-by: Mamta Singh <mamtsing@qti.qualcomm.com>
quic-dhirajku pushed a commit to quic-dhirajku/efficient-transformers that referenced this pull request Aug 4, 2025
…uic#371)

1. Implement logger for finetuning
2. enable dumping logs by given flag

---------

Signed-off-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Co-authored-by: Mamta Singh <mamtsing@qti.qualcomm.com>
Signed-off-by: Dhiraj Kumar Sah <dhirajku@qti.qualcomm.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants