Skip to content

[Junie]: feat: add start method to JMX Connector operations #1018

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Junie]: feat: add start method to JMX Connector operations #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions quickfixj-core/src/main/java/org/quickfixj/jmx/mbean/connector/ConnectorAdmin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import quickfix.Acceptor;
import quickfix.ConfigError;
import quickfix.Connector;
import quickfix.Initiator;
import quickfix.RuntimeError;
import quickfix.Session;
import quickfix.SessionID;
import quickfix.SessionSettings;
Expand Down Expand Up @@ -142,6 +144,15 @@ private ObjectName[] toObjectNameArray(List<ObjectName> sessions) {
return sessions.toArray(new ObjectName[sessions.size()]);
}

public void start() throws IOException {
log.info("JMX operation: start {} {}", getRole(), this);
try {
connector.start();
} catch (ConfigError | RuntimeError e) {
throw JmxSupport.toIOException(e);
}
}

public void stop(boolean force) {
log.info("JMX operation: stop {} {}", getRole(), this);
connector.stop(force);
Expand Down
7 changes: 7 additions & 0 deletions quickfixj-core/src/main/java/org/quickfixj/jmx/mbean/connector/ConnectorAdminMBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ public interface ConnectorAdminMBean {
*/
String getRole() throws IOException;

/**
* Start the connector.
*
* @throws IOException if there is a problem starting the connector
*/
void start() throws IOException;

/**
* Stop the connector.
*
Expand Down