Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Send(Messagable) which does not account for TargetSubID & SenderSubID #514

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Sep 26, 2022

Signed-off-by: Sylvain Rabot sylvain@abstraction.fr

@ackleymi
Copy link
Member

ackleymi commented May 8, 2023

@sylr If you added a test or two here to ensure accessing these fields in the header doesn't cause any issues here if they don't exist, I will merge it right away

…ubID

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
@sylr sylr changed the title Account for TargetSubID & SenderSubID Fix Send(Messagable) which does not account for TargetSubID & SenderSubID Feb 25, 2025
@sylr
Copy link
Contributor Author

sylr commented Mar 4, 2025

@ackleymi I've added a test as requested.

@sylr
Copy link
Contributor Author

sylr commented Mar 18, 2025

@ackleymi could you please review this ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants