Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

QuTiPv5 Paper Notebook: Non-Markovian mcsolve #117

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Langhaarzombie
Copy link
Contributor

@Langhaarzombie Langhaarzombie commented Nov 27, 2024

This adds the non-Markovian Monte Carlo examples from the paper to the tutorials. Essentially, it includes the damped Jaynes-Cumming model and the comparison of nm_mcsolve with HEOM and brsolve.

TODO:

  • Testing

- replicated plots from paper
- added introduction and explanations in own words
- added general structure for notbeook such as about, etc.
- added tests relying on proximity of the solutions
- rewrote instructions so they are less like the paper and more clear
- fixed typos and improved code structure
@Langhaarzombie Langhaarzombie marked this pull request as ready for review November 28, 2024 06:11
@Langhaarzombie
Copy link
Contributor Author

Langhaarzombie commented Nov 28, 2024

Although it is ready for review, we should still wait until an official arXiv link is available to the QuTiP 5 paper as this reference link is blank at the moment.

  • Include official url to QuTiP 5 paper

Copy link
Member

@pmenczel pmenczel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side (however, let's wait with merging)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants