refactor(utils): move extract-theme to a separate package #1051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Why is it needed?
Rollup seems confused by the nx (maybe applies to all monorepos) graph, maybe because qwik-ui uses CJS. We have one generic util package in qwik-ui with the
cn
helper that we use everywhere and theextractThemeCSS
(which usesspecificity
and thereforecss-tree
) that we use only in one place. The result with that shared Nx package is that rollup bundlescn
withcss-tree
, and then the q-bundle-graph wants to statically import and therefore prefetch that chunk almost on every other chunks. If I separate those utils into 2 separate Nx packages, rollup doesn't bundle them together anymore, resulting in onlycn
being imported almost everywhere - which is expected since we use it almost everywhere.Checklist:
pnpm change
and documented my changes