First draft for in_linter() #2621
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it might be nice to be able to tweak a minimum nesting depth, i.e., number of repeated Also note there is different behavior with respect to |
|
Hi @Bisaloo, do you want to revive this :) HTH |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to fix #1875.
Questions:
scalar_in_linter()be merged with this linter? I see these two linters are counterpart to one another.Unaddressed cases:
x == 'a' | y == 'b' | x == 'c'are not covered at this time but I would assume most people at least group the tests by variable(?) so it's maybe okay to leave it for now.