Skip to content

Remove some tests of internal API #2801

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Feb 27, 2025

Closes #1692.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.25%. Comparing base (0a47a3f) to head (cb67e96).

Files with missing lines Patch % Lines
R/make_linter_from_regex.R 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2801      +/-   ##
==========================================
- Coverage   99.64%   99.25%   -0.39%     
==========================================
  Files         127      127              
  Lines        6989     6969      -20     
==========================================
- Hits         6964     6917      -47     
- Misses         25       52      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelChirico MichaelChirico changed the title Remove internal API test (make_linter_from_regex) Remove some tests of internal API Feb 27, 2025
@MichaelChirico
Copy link
Collaborator Author

Wait for #2802

@MichaelChirico MichaelChirico marked this pull request as ready for review May 8, 2025 05:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use public interface in tests wherever possible (don't use :::)
2 participants