Add grepv() awareness to the package #2856
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 127 127
Lines 7068 7070 +2
=======================================
+ Hits 7043 7045 +2
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -72,7 +72,7 @@ regex_subset_linter <- function() { | |||
| grep_expr, | |||
| source_expression = source_expression, | |||
| lint_message = | |||
| "Prefer grep(pattern, x, ..., value = TRUE) over x[grep(pattern, x, ...)] and x[grepl(pattern, x, ...)].", | |||
| "Prefer grepv(pattern, x, ...) over x[grep(pattern, x, ...)] and x[grepl(pattern, x, ...)].", | |||
There was a problem hiding this comment.
Can we maybe customize this error message based on the R version since lintr is still compatible with R 4.0 to 4.4, which don't know about grepv()?
There was a problem hiding this comment.
I wouldn't go that way, since the process running {lintr} can be different from the DESCRIPTION dependency, or any other number of incompatibilities between the report and the actual intention.
WDYT about just adding
Use {backports} if your code might also run on R versions before 4.5.0.
There was a problem hiding this comment.
Sounds good in theory but we would have to wait until r-lib/backports#88 is merged and a new version of backports released.
Maybe the safest option is to be more verbose:
Prefer grepv(pattern, x, ...), or grep(pattern, x, value = TRUE) if your code might also run on R versions before 4.5.0, over x[grep(pattern, x, ...)] and x[grepl(pattern, x, ...)].
There was a problem hiding this comment.
Adjusted, PTAL.
Yea, I've been meaning to file that as an issue for a new linter (presumably |
|
Also fixes #2648 I think. |
Closes #2855. Closes #2648. Progress on #2737