Automated Resyntax fixes #1431
Open
Automated Resyntax fixes #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
The `define` form supports a shorthand for defining functions.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `define-syntax` macro can be replaced with a simpler, equivalent `define-syntax-rule` macro.
This `if` expression can be refactored to an equivalent expression using `and`.
This negated `when` expression can be replaced by an `unless` expression.
This expression is equivalent to calling the `positive?` predicate.
The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`.
Providing the same identifier multiple times is unnecessary.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
The `apply` function accepts single arguments in addition to a trailing list argument.
This `match` expression can be simplified using `match-define`.
This use of `define-values` is unnecessary.
This quasiquotation is equialent to a simple `list` call.
This `sort` expression can be replaced with a simpler, equivalent expression.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
Only one of the `for/fold` expression's result values is used. Use the `#:result` keyword to return just that result.
Instead of using `(apply append ...)` to flatten a list of lists, consider using `for*/list` to flatten the list.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
samth
reviewed
Jan 27, 2025
| (locate-stx e)) | ||
| e)))) | ||
| (define l (current-logger)) | ||
| (locate-stx e) |
There was a problem hiding this comment.
Losing this binding isn't wanted, although I see how it happened.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 50 issues in 18 files.
let-to-definesingle-clause-match-to-match-definedefine-syntax-syntax-rules-to-define-syntax-rulequasiquote-to-listif-else-false-to-andsort-with-keyed-comparator-to-sort-by-keyzero-comparison-to-positive?define-values-values-to-definedefine-simple-macro-to-define-syntax-parse-rulecond-let-to-cond-defineif-let-to-condprovide-deduplicationwhen-expression-in-for-loop-to-when-keywordfor/fold-result-keywordapply-append-for-loop-to-for-loopalways-throwing-if-to-wheninverted-whenmap-to-forapply-flatteningdefine-lambda-to-define