Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update redis.rb #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update redis.rb #11

wants to merge 2 commits into from

Conversation

clwy-cn
Copy link

@clwy-cn clwy-cn commented Mar 17, 2025

image
修复如上问题

huacnlee
huacnlee approved these changes Mar 17, 2025
View reviewed changes
lib/status-page/services/redis.rb
rescue Exception => e
raise RedisException.new(e.message)
ensure
redis.close if redis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redis&.close

lib/status-page/services/redis.rb
raise RedisException.new(e.message)
ensure
redis.close
redis = nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not need this

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@huacnlee huacnlee huacnlee approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clwy-cn @huacnlee