Skip to content

Multi-line f-string for vs code configuration file contents #87

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: update_vscode_json_to_sdk1_5
Choose a base branch
from

Conversation

paulober
Copy link
Contributor

@paulober paulober commented Jul 6, 2023

No description provided.

"cmake.buildBeforeRun": true,
"cmake.configureOnOpen": true,
"cmake.configureSettings": {{
"CMAKE_MODULE_PATH": "${{env:PICO_INSTALL_PATH}}/pico-sdk-tools"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, PICO_INSTALL_PATH only exists on Windows when the installer is used. Should be harmless otherwise but should be tested I think.

@ndabas
Copy link

ndabas commented Jul 7, 2023

Not exactly related to what this PR is addressing, but a somewhat larger discussion: should we consider keeping all of these config files in a single source somewhere? As it stands we have three "official" locations:

Users are certainly confused about which set is the latest and greatest one, so it would make sense to have just one location.

I think the pico-examples repo might be a good candidate, because that would work for people using our installer or generator, and also for people DIY'ing their toolchain. I can set up the installer to pull from the pico-examples repo. Maybe we can set up the generator to do the same, or include it in releases.

@JamesH65
Copy link
Contributor

JamesH65 commented Jul 7, 2023

I have been wondering about converting this part of the generator to use some sort of template which the generator then fills in the fields. Those templates could be anywhere.

Jinja was one templating library that has been suggested.

@lurch
Copy link
Contributor

lurch commented Jul 7, 2023

Not exactly related to what this PR is addressing, but a somewhat larger discussion: should we consider keeping all of these config files in a single source somewhere?

That sounds like an excellent question. Ping @P33M @kilograham @ghollingworth

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants