support parsing client-cache invalidation messages #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhelmich
force-pushed
the
mh/parse-invalidate-subscription-message
branch
10 times, most recently
from
d253629 to
999b49e
Compare
mhelmich
changed the title
mhelmich
force-pushed
the
mh/parse-invalidate-subscription-message
branch
from
999b49e to
13c3db3
Compare
mhelmich
force-pushed
the
mh/parse-invalidate-subscription-message
branch
4 times, most recently
from
90cc0d3 to
eba9a0f
Compare
mhelmich
force-pushed
the
mh/parse-invalidate-subscription-message
branch
from
eba9a0f to
4c6d248
Compare
|
Hi @chayim and @ofekshenawa 👋 |
atharva29
reviewed
Sep 9, 2024
| invalidateClient.Close() | ||
|
|
||
| mu.Lock() | ||
| invalidateClientID = -1 |
There was a problem hiding this comment.
Why don't you use atomic.Int32 to update this variable
such that !
- Mutex will get removed
2.on line [617] (support parsing client-cache invalidation messages #3007 (comment)) you are already locking the mutex, so there is a chance of double locking mutex
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing redis client-side caching invalidation messages.
Today, these messages are not parsed properly and an error is returned instead.
With this PR, messages are parsed into a
Messageand the array of invalidated cache key is passed to the caller insidePayloadSliceof the message.This PR does not add a cache to the client or enables the client-side caching feature. It merely plumbs invalidation messages through to the caller. A caching mechanism can (and has to) be built on top of this change.
Details about redis' client-side caching feature can be found here: https://redis.io/docs/latest/develop/use/client-side-caching/