feat: add encoding.BinaryUnmarshaler in Scan #3144
Open
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeze1004
force-pushed
the
#3139-add-encoding-BinaryUnmarshaler-scan
branch
2 times, most recently
from
2ea6e51 to
72cdd5c
Compare
zeze1004
force-pushed
the
#3139-add-encoding-BinaryUnmarshaler-scan
branch
from
72cdd5c to
a5a0e2f
Compare
zeze1004
force-pushed
the
#3139-add-encoding-BinaryUnmarshaler-scan
branch
from
98b44f0 to
de72ae7
Compare
|
Hi there, I was wondering if you could take a moment to review this PR when you have the time. Thanks! cc. @ofekshenawa, @monkey92t |
ofekshenawa
approved these changes
Nov 20, 2024
zeze1004
force-pushed
the
#3139-add-encoding-BinaryUnmarshaler-scan
branch
from
de72ae7 to
f97720d
Compare
zeze1004
force-pushed
the
#3139-add-encoding-BinaryUnmarshaler-scan
branch
from
f97720d to
7fcc39c
Compare
|
This one looks good to me. @zeze1004 do you think we can add full test with write and read from/to redis instance? |
Sorry, I just checked, I'll add the test and mention it |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #3139
Fixed issue where UUID fields could not be unmarshaled correctly.