feat: Create and alias index #813
Conversation
|
Hi @SoulPancake, I just reviewed it again and left some comments. Could you also write some tests to demonstrate how a user can use this feature? |
|
|
||
| newIndex := alias + "_v1" | ||
| if aliasExists && currentIndex != "" { | ||
| // Find the last occurrence of "_v" followed by digits |
There was a problem hiding this comment.
What do you think about this? @rueian
There was a problem hiding this comment.
LGTM. Please update for the JSONRepository as well.
om/hash.go
Outdated
| var currentIndex string | ||
| infoCmd := r.client.B().FtInfo().Index(alias).Build() | ||
| infoResp, err := r.client.Do(ctx, infoCmd).ToMap() | ||
| aliasExists := err == nil |
There was a problem hiding this comment.
What will be the error returned when the index does not exist? Will it be a redis Nil? I think we should return early here if the err is caused by other reasons, such as network failures.
Co-authored-by: Rueian <rueiancsie@gmail.com>
| infoCmd := r.client.B().FtInfo().Index(alias).Build() | ||
| infoResp, err := r.client.Do(ctx, infoCmd).ToMap() | ||
| if err != nil { | ||
| if strings.Contains(err.Error(), "Unknown index name") { |
There was a problem hiding this comment.
I think this should work @rueian
There was a problem hiding this comment.
ok. please write tests for that.
There was a problem hiding this comment.
sure, will do the changes in JSON as well and then write UTs
No description provided.