Skip to content

Classic selection: calculate line width #81

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Classic selection: calculate line width #81

wants to merge 2 commits into from

Conversation

daltomi
Copy link
Collaborator

@daltomi daltomi commented Apr 1, 2021

Replace #79

@daltomi
Copy link
Collaborator Author

daltomi commented Apr 2, 2021

At the moment it works when the line width is 1px, but not when it is greater.

@daltomi daltomi mentioned this pull request Apr 2, 2021
Closed
@daltomi
Copy link
Collaborator Author

daltomi commented Jul 30, 2021

I call this PR "pixel perfect selection" :P
@keysym Sorry, I haven't seen how to fix it yet.

@daltomi daltomi added the help wanted Extra attention is needed label Jul 30, 2021
@keysym
Copy link
Contributor

keysym commented Jul 31, 2021

Great name :p

No problem, I also haven't checked this problem for a while... Also, this is a hard problem to be testing!
I'm trying to get back on learning C, so I'll definitely give it a try, again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daltomi @keysym