feat(pb): add runner logs #2447
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2025
Deploying rivet with
|
| Latest commit: |
ed03e29
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09d1c12c.rivet.pages.dev |
| Branch Preview URL: | https://05-16-feat-pb-add-runner-log.rivet.pages.dev |
MasterPtato
force-pushed
the
05-16-feat_pb_add_runner_logs
branch
from
80d633b to
9b820e0
Compare
MasterPtato
force-pushed
the
05-08-feat_add_runners_to_pb_protocol
branch
from
542b3c5 to
885534d
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements runner logging functionality by adding actor-specific log tracking and storage capabilities across the container-runner and manager services.
- Adds new
runner_logsClickHouse table with 3-day TTL and hourly partitioning in20200101000000_init.up.sql - Enhances
LogShipperto support optionalactor_idfor associating logs with specific actors inlog_shipper.rs - Implements Vector integration for log shipping with proper handling of single vs multi-allocation runners in
main.rs - Modifies Runner module to track actor-specific logs and handle different allocation types in
runner/mod.rs - Updates Actor module to properly associate logs with actors based on allocation type in
actor/mod.rs
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This was referenced May 22, 2025
MasterPtato
force-pushed
the
05-16-feat_pb_add_runner_logs
branch
from
9b820e0 to
ed03e29
Compare
MasterPtato
force-pushed
the
05-08-feat_add_runners_to_pb_protocol
branch
from
885534d to
d0f985a
Compare
Deploying rivet-studio with
|
| Latest commit: |
ed03e29
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://809c4463.rivet-studio.pages.dev |
| Branch Preview URL: | https://05-16-feat-pb-add-runner-log.rivet-studio.pages.dev |
This was referenced May 27, 2025
Deploying rivet-hub with
|
| Latest commit: |
ed03e29
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d7eebe63.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://05-16-feat-pb-add-runner-log.rivet-hub-7jb.pages.dev |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes