feat(hub): add actors billing preview #2466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet-studio with
|
| Latest commit: |
76ea7d9
|
| Status: | 🚫 Build failed. |
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. # using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Test" took an action on this PR • (05/21/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
Deploying rivet-hub with
|
| Latest commit: |
76ea7d9
|
| Status: | 🚫 Build failed. |
Deploying rivet with
|
| Latest commit: |
76ea7d9
|
| Status: | 🚫 Build failed. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Introduces actor-based billing preview functionality with a new ActorsBillingUsage component and refactored billing calculations.
- Added
ActorsBillingUsagecomponent in/frontend/apps/hub/src/domains/project/components/billing/actors-billing-usage.tsxto display billing usage for actors - Refactored billing context in
billing-context.tsxto use server-side aggregate billing queries instead of local calculations - Added new
calculateUsedActorCreditsfunction inbilling-calculate-usage.tswith a 1.1x overhead factor - Changed actor query pagination to
Number.POSITIVE_INFINITYin multiple files which may impact performance - Missing required
projectIdprop inbilling-view.tsxwhen renderingActorsBillingUsagealongsideMissingPaymentMethod
16 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/apps/hub/src/domains/project/components/billing/actors-billing-usage.tsx
Outdated
Show resolved
Hide resolved
frontend/apps/hub/src/domains/project/components/billing/actors-billing-usage.tsx
Outdated
Show resolved
Hide resolved
frontend/apps/hub/src/domains/project/components/billing/billing-context.tsx
Show resolved
Hide resolved
frontend/apps/hub/src/domains/project/components/billing/billing.tsx
Outdated
Show resolved
Hide resolved
| projectId={projectId} | ||
| groupId={developerGroupId} | ||
| /> | ||
| <ActorsBillingUsage /> |
There was a problem hiding this comment.
logic: Missing required projectId prop for ActorsBillingUsage component. This will cause runtime errors since the component uses this prop internally.
Suggested change
| <ActorsBillingUsage /> | |
| <ActorsBillingUsage projectId={projectId} /> |
...henticated/_layout/projects/$projectNameId/environments/$environmentNameId._v2/functions.tsx
Show resolved
Hide resolved
jog1t
force-pushed
the
05-21-feat_hub_add_actors_billing_preview
branch
from
ac1b42f to
edb251e
Compare
jog1t
force-pushed
the
05-21-feat_hub_add_actors_billing_preview
branch
4 times, most recently
from
9aea382 to
c027938
Compare
This was referenced Jun 4, 2025
jog1t
force-pushed
the
05-21-feat_hub_add_actors_billing_preview
branch
from
c027938 to
20a4f29
Compare
jog1t
force-pushed
the
05-21-feat_hub_add_actors_billing_preview
branch
from
20a4f29 to
76ea7d9
Compare
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes